Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
numericalDerivative11(lambda x: x ** 2, 3.0)fails becauseretractpromotes the scalar input to a one-element array, andlocalrejects the resulting type mismatch. NumPy scalar inputs such asnp.float32andnp.int64also fall through to an unavailable.retractmethod. The existing scalar test uses a one-element array, so it does not cover these cases.Keep scalar perturbations scalar, using double precision consistently with
local, and permit mixed numeric scalar types when computing local coordinates. Array and manifold behavior is unchanged, including rejecting array/scalar mismatches. This does not preserve the input scalar dtype or arbitrary precision.Tests cover Python float/int and NumPy float32/float64/int64 at zero, negative and positive values, mixed scalar local coordinates, scalar-only callbacks, and vector-valued residuals.
Validation:
git diff --checkpasses. Ruff has only three pre-existing findings in these files (F841, UP035 and I001); no new findings remain.Python tests use the current source utility with native bindings from the official
gtsam-develop 4.3.2.dev202611100512wheel. No C++ or MATLAB build was run, and no bindings were changed.This change was prepared and tested with AI assistance.